I'm a big fan of the current bus station. I take the bus to Quebec City with Orleans Express about once a month so I've been here many times already. It's clean, well-lit and feels safe even at night. There's a Presse Café and convenience store open late.
I don't like going through the old station to reach Berri Metro because of the urine smell and the questionable people you can sometimes meet there. From outside it's less than 5 minutes away from the subway station. I found that accessing the subway through the public library (when it's open) is the way which involves the least time outdoors.